-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Remote IP Address - NULL reference exception #3481
Conversation
fix Remote IP Address - NULL reference exception
|
@nayang7 thanks for your contribution! Would you clear the CLA and update the changelog? (and ideally add a test case) |
@reyang I have updated the changelog and CLA was resolved, btw, I have to say current didn't have test file about '(OpenTelemetry.Instrumentation.AspNetCore/Implementation)/HttpInListener.cs' so it's really hard to test Http here. |
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@reyang hey reyang, it seems 'First-time contributors need a maintainer to approve running workflows.' |
I just approved the CI workflows. |
@reyang hey reyang, sorry it's my fault, I didn't notice all the format error msg, I just updated fixing 'error SA1513: Closing brace should be followed by blank line'. Thanks your approve again. |
@reyang hey reyang, the format really confused me, need your approval again for 'SA1028 Code Should Not Contain Trailing Whitespaces', thanks. |
Codecov Report
@@ Coverage Diff @@
## main #3481 +/- ##
==========================================
+ Coverage 86.43% 86.59% +0.15%
==========================================
Files 275 275
Lines 9977 9978 +1
==========================================
+ Hits 8624 8640 +16
+ Misses 1353 1338 -15
|
@reyang @cijothomas Just now it seems the checking all passed and with coverage report. Since it lasts several days, just Update branch, then needs approval again. Thanks |
@reyang @cijothomas it seems API Compatibility build-test failed after I update branch 'D:\a\opentelemetry-dotnet\opentelemetry-dotnet\build\Common.prod.props(20,5): error MSB3073: The command "powershell -ExecutionPolicy Unrestricted -File "D:\a\opentelemetry-dotnet\opentelemetry-dotnet\build\PreBuild.ps1" -package OpenTelemetry -version "1.3.0"" exited with code 1. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry\OpenTelemetry.csproj] |
That is a bit flaky test. However it is not mandatory check, so won't block this PR. |
@cijothomas thanks, I have rebased |
fix Remote IP Address - NULL reference exception
Fixes #3276.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes